Add xpub announce UI and peer xpubs display to desktop#287
Merged
kwsantiago merged 3 commits intomainfrom Feb 27, 2026
Merged
Conversation
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (4)
WalkthroughThe PR adds an XPub announcement workflow to the Keep desktop application. New message types and state structures enable users to announce recovery keys to a FROST node with fingerprint and label metadata. Event handling merges incoming announced xpubs into the wallet screen state. Changes
Sequence DiagramsequenceDiagram
actor User
participant App as App<br/>(Message Handler)
participant Wallet as Wallet<br/>(UI & State)
participant FROST as FROST Node
User->>App: WalletStartAnnounce
App->>Wallet: Initialize AnnounceState
Note over Wallet: announce = Some(AnnounceState)
User->>App: WalletAnnounceXpubChanged(xpub)
App->>Wallet: Update announce.xpub
User->>App: WalletAnnounceFingerprintChanged(fp)
App->>Wallet: Update & sanitize announce.fingerprint
User->>App: WalletAnnounceLabelChanged(label)
App->>Wallet: Update announce.label
User->>App: WalletSubmitAnnounce
App->>FROST: Submit AnnouncedXpub
FROST-->>App: XpubAnnounced event
App->>Wallet: WalletAnnounceResult(Ok)
Wallet->>Wallet: Clear announce state
App->>Wallet: Merge recovery_xpubs → peer_xpubs
Note over Wallet: Display announced xpubs
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (1)
keep-desktop/src/app.rs (1)
1481-1523: Add defensive validation in submit handler (not just UI).
Message::WalletSubmitAnnounceshould reject obviously invalid payloads before callingannounce_xpubs, even if the button is normally disabled in the view.✅ Proposed hardening
Message::WalletSubmitAnnounce => { let (xpub, fingerprint, label) = if let Screen::Wallet(WalletScreen { announce: Some(a), .. }) = &mut self.screen { a.submitting = true; a.error = None; ( a.xpub.trim().to_string(), a.fingerprint.trim().to_string(), a.label.trim().to_string(), ) } else { return Task::none(); }; + + let valid_prefixes = [ + "xpub", "tpub", "ypub", "zpub", "upub", "vpub", "Ypub", "Zpub", "Upub", "Vpub", + ]; + let xpub_valid = valid_prefixes.iter().any(|p| xpub.starts_with(p)); + let fp_valid = + fingerprint.len() == 8 && fingerprint.chars().all(|c| c.is_ascii_hexdigit()); + if !xpub_valid || !fp_valid { + if let Screen::Wallet(WalletScreen { announce: Some(a), .. }) = &mut self.screen { + a.error = Some("Invalid xpub or fingerprint".into()); + a.submitting = false; + } + return Task::none(); + }
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@keep-desktop/src/frost.rs`:
- Around line 823-827: The current loop that inserts into ws.peer_xpubs at
share_index only checks xpub.xpub and skips already-existing entries, which
prevents metadata updates; modify the logic in the block handling
ws.peer_xpubs.entry(share_index) and the for xpub in recovery_xpubs loop to
perform an upsert: search entry for an existing item where .xpub == xpub.xpub,
and if found update its metadata fields (e.g., label, fingerprint or other
refreshed fields) by assigning them from the incoming xpub, otherwise push the
new xpub into entry; make sure to reference and update the exact struct fields
used elsewhere in the code so UI reflects re-announcements.
In `@keep-desktop/src/message.rs`:
- Around line 539-546: The Debug implementation is currently exposing sensitive
user-entered metadata for the enum variants WalletAnnounceFingerprintChanged and
WalletAnnounceLabelChanged; update the Debug branch for those variants in the
Debug impl so they do not print the raw fp or l values (e.g., emit a constant
redacted placeholder like "<redacted>" or a masked representation such as
showing only length/last 4 chars) instead of .field(fp) / .field(l), ensuring
other variants remain unchanged and the enum name still appears in the debug
output.
In `@keep-desktop/src/screen/wallet.rs`:
- Around line 603-605: The code constructs truncated via byte-slicing
xpub.xpub[..32], which can panic on UTF-8 multibyte characters; change the logic
that builds truncated (the truncated variable using xpub.xpub) to operate on
characters instead of bytes: check character count with
xpub.xpub.chars().count() and build the prefix with
xpub.xpub.chars().take(32).collect::<String>(), then append "..." when
truncated, ensuring you return the original string when not truncated.
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
keep-desktop/src/app.rskeep-desktop/src/frost.rskeep-desktop/src/message.rskeep-desktop/src/screen/wallet.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Release Notes