Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/opc tool #368

Merged
merged 7 commits into from
Jan 25, 2024
Merged

Features/opc tool #368

merged 7 commits into from
Jan 25, 2024

Conversation

haraldsteinlechner
Copy link
Collaborator

extended opc-tool with dds functionality and dotnet-tool packaging, see: https://github.com/pro3d-space/PRo3D/blob/features/opc-tool/docs/OpcTool.md

touched files: build scripts, and src/opc-tool.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the variable name be quiet instead of quite? Since it controls logging output?

let isOpcFolder' (quite : bool) (path : string) =

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in: 6095bf0

Copy link
Collaborator

@RebeccaNowak RebeccaNowak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found one possibly confusing argument name "quite" instead of "quiet" (added note in review)

@RebeccaNowak RebeccaNowak merged commit 3afd9ef into develop Jan 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants