-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Local transformations & new LoD Metric #495
base: develop
Are you sure you want to change the base?
Conversation
…revents those firewall warnings!
…phic annotation performance (in e.g. shaler) [(String.IsNullOrEmpty text) || (show && visible)] #481
… for large models due to per-value field containing the whole drawing state)
… loading the lowest quality kdtree unfortunately is too expensive, so i teaked the old legacy metric
…iate frames instead of classic scalbars (renamed ScaleBar to ScaleVisualization to reflect his additional visualization behavior), Outline rendering: optional parameter for thickness
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to avoid confusions, i suggest we do some simple UI hints / tooltips etc in addition to a markdown documentation in /docs explaining the more complex bits of the transformations
@@ -689,15 +689,15 @@ module ScaleBarsApp = | |||
let inRefFrame = | |||
refSys.Current | |||
|> AVal.map (fun refSys -> | |||
TransformationApp.getReferenceSystemBasis V3d.Zero refSys | |||
TransformationApp.getReferenceSystemBasis_global refSys //TODO: local or global? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this could be controllable in scalebar settings. Since this could be a source of confusion i suggest adding at least a note in the UI
recomendet workflow:
Note: this approach is only useful for small translations. big translations and a new position of the local reference system effect a relocation of the surface.