Add probe state machine #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See also iand/zikade#3 |
dennis-tra
approved these changes
Sep 1, 2023
routing/probe.go
Outdated
Comment on lines
113
to
116
| Clock: clock.New(), // use standard time | ||
| Concurrency: 3, | ||
| Timeout: time.Minute, | ||
| CheckInterval: 6 * time.Hour, |
There was a problem hiding this comment.
Suggested change
| Clock: clock.New(), // use standard time | |
| Concurrency: 3, | |
| Timeout: time.Minute, | |
| CheckInterval: 6 * time.Hour, | |
| Clock: clock.New(), // use standard time | |
| Concurrency: 3, // MAGIC | |
| Timeout: time.Minute, // MAGIC | |
| CheckInterval: 6 * time.Hour, // MAGIC |
There was a problem hiding this comment.
Jorropo suggested this to mark values we pulled out of thin air
routing/probe.go
Outdated
| func (u unaddressedNodeInfo[K, A]) ID() kad.NodeID[K] { return u.NodeID } | ||
| func (u unaddressedNodeInfo[K, A]) Addresses() []A { return nil } | ||
|
|
||
| // ProbeState is the state of a probe. |
There was a problem hiding this comment.
Suggested change
| // ProbeState is the state of a probe. | |
| // ProbeState is the state of the [Probe] state machine. |
| cfg.CheckInterval = -1 | ||
| require.Error(t, cfg.Validate()) | ||
| }) | ||
| } |
There was a problem hiding this comment.
nit, all the above require could be assert's
|
|
||
| nv2 := &nodeValue[key.Key8]{ | ||
| NodeID: kadtest.NewID(key.Key8(4)), | ||
| NextCheckDue: clk.Now().Add(-time.Minute), |
There was a problem hiding this comment.
Might be worth enforcing that even if nv2.NextCheckDue is after nv1.NextCheckDue the value will be replaced. So that we're not clever in that regard.
dennis-tra
reviewed
Sep 1, 2023
guillaumemichel
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the initial state machine for running regular connectivity checks against nodes in the routing table. Scoring of useful nodes is not included and is to be added in a later change.
Part of #45