Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7030
My plan here is to refactor how WebGL mode is structured to make it more understandable to contributors and to reduce duplication. At a high level:
GeometryBuilder
classp5.Geometry
, they just have different methods for creating and storing geometry, so those systems should be factored out, leaving common rendering codeSpecific changes and progress so far:
p5.Geometry
into one spot; currently it has a lot of duplication between immediate and retained modeShapeBuilder
classretainedMode.geometry
to be more descriptive: this is what stores the WebGL buffer references, not the geometry itselfretainedMode.geometry[gid]
; for immediate mode it just gets dumped right on the immediate mode'sp5.Geometry
. These should be handled the same wayp5.Shader
, and half are set viap5.RendererGL
p5.Geometry
everywhere instead of accessing the cache directly via thegid
property