Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mod_s3_upload: better object name generation #329

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

Guerteltier
Copy link
Contributor

No description provided.

@prefiks
Copy link
Member

prefiks commented Feb 2, 2024

Hello,

Did you test that and seen that this works correctly? This switches from .../... to .../.../... and i am not sure if s3 do support that extra path depth?

@Guerteltier
Copy link
Contributor Author

S3 doesn't really have a concept of folders.

Amazon S3 supports buckets and objects, and there is no hierarchy. However, by using prefixes and delimiters in an object key name, the Amazon S3 console and the AWS SDKs can infer hierarchy and introduce the concept of folders.
https://docs.aws.amazon.com/AmazonS3/latest/userguide/object-keys.html

I tested the changes with Backblaze B2, but they should work with S3 as well.

@Guerteltier
Copy link
Contributor Author

The main improvement in my opinion is that now it doesn't cause a prefix to be added to the names of uploaded files.

@prefiks prefiks merged commit b563d1e into processone:master Feb 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants