Conversation
- Updated gemspec to support ActiveRecord versions up to 8.2 - Added test configurations for ActiveRecord 8.0 and 8.1 - Added test configurations with strong_migrations integration - Generated gemfiles for all new configurations - All tests passing (13 examples, 0 failures) for both 8.0.3 and 8.1.0 - Updated CHANGELOG.md to document new Rails support Signed-off-by: joe-sharp <joe.sharp@procore.com>
Signed-off-by: joe-sharp <joe.sharp@procore.com>
Signed-off-by: joe-sharp <joe.sharp@procore.com>
Signed-off-by: joe-sharp <joe.sharp@procore.com>
Signed-off-by: joe-sharp <joe.sharp@procore.com>
6ca3856 to
0e299a0
Compare
Signed-off-by: joe-sharp <joe.sharp@procore.com>
368d25d to
abf16ee
Compare
Signed-off-by: joe-sharp <joe.sharp@procore.com>
Signed-off-by: joe-sharp <joe.sharp@procore.com>
Signed-off-by: joe-sharp <joe.sharp@procore.com>
29d5294 to
c7199a6
Compare
lessthanjacob
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial commit comes from: #23
Thank you pjmartorell !
Additionally it looks like we need to require Ruby 3.2 for at least ActiveRecord 8.0+. This should be reasonable to do since Ruby 3.1 has been EOL for almost a year:
PR Description from the original PR:
Summary
This PR adds support for ActiveRecord 8.0 and 8.1 to the
migration-lock-timeoutgem.Resolves #22
Changes
Gemspec
< 8.0to< 8.2Test Configurations
Added 4 new Appraisal configurations:
activerecord_8_0- Testing with ActiveRecord 8.0.xactiverecord_8_0_with_strong_migrations- Testing 8.0 with strong_migrations integrationactiverecord_8_1- Testing with ActiveRecord 8.1.xactiverecord_8_1_with_strong_migrations- Testing 8.1 with strong_migrations integrationDocumentation
CHANGELOG.mdto document new Rails 8.0 and 8.1 supportTesting
All tests pass successfully across all new configurations:
activerecord_8_0activerecord_8_0_with_strong_migrationsactiverecord_8_1activerecord_8_1_with_strong_migrationsCompatibility Analysis
The gem's implementation uses only stable ActiveRecord APIs that have remained unchanged in Rails 8.x:
ActiveRecord::Migrationprepending and extendingexecutemethod for SQL commandsdisable_ddl_transactionattribute:upvs:down)Rails 8.0 and 8.1 introduce no breaking changes to these migration APIs, ensuring full compatibility.
Version Support Matrix
With this change, the gem now supports:
Checklist: