Revert "patch: Update regex to match both HTML & Markdown docs paths" #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klutchell
approved these changes
Dec 17, 2024
vipulgupta2048
force-pushed
the
revert-120-vipulgupta2048-patch-1
branch
from
13d1ad5 to
5a0a1cb
Compare
|
Website deployed to CF Pages, 👀 preview link https://3fcc035a.docusaurus-builder.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #120
Reverting. Doesn't work for Flowzone readme. For example, this regex change replaces the path to create
././images/logo.png-->docs/docs/images/logo.pngwhich wasn't apparent in the testing since we are using relative links.The actual error:
Cause: Image docs/docs/images/logo.png used in docs/README.md not found.To unblock further updates of the docusaurus builder into Flowzone. I am reverting this change.