Remove node version from artifact names #1346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Website deployed to CF Pages, 👀 preview link https://a548aad7.flowzone.pages.dev |
klutchell
force-pushed
the
kyle/npm-download
branch
from
7c2b8a3 to
765bcb0
Compare
klutchell
changed the title
klutchell
force-pushed
the
kyle/npm-download
branch
from
765bcb0 to
8e4dbd1
Compare
The artifact download regex on finalize treats the node version string as optional, and we only upload a single node artifact matching the max version anyway. Change-type: minor Signed-off-by: Kyle Harding <kyle@balena.io>
This avoids artifact download failures when the node version changes between draft and merge. CHange-type: patch Signed-off-by: Kyle Harding <kyle@balena.io>
klutchell
force-pushed
the
kyle/npm-download
branch
from
8e4dbd1 to
d7f9ddd
Compare
pipex
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids artifact download failures when the node version changes between draft and merge.