Add missing properties to data model Source #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
development-motoin
requested review from
takeit,
plehatron,
pupbot and
m038-pup
and removed request for
a team
medbak
requested review from
a team and
medbak
and removed request for
a team
|
Any new information on this? |
takeit
previously approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both
GET sites/<siteId>/sourcesandGET sites/<siteId>/streamsprovide some data fields in their response within keysources( (see PlatformAPI-Documentation). Some of them are not supported by this lib so far.Missing fields so far:
Supported fields right now:
This PR add support of the missing fields mentioned above. In our webshop, we particularly need access to the settings field, as it lists the streams linked to a site, among other things. We don't want to hardcode this settings in our project, but rather use the current settings fetched from Platform-API.