Multi prop #757
Open
Multi prop #757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding EVENT_**_HELD_XTRA_LONG for multi_prop.h
Adding multipropdisplaycontroller
morsecodedisplaycontroller code commented out until morsecode_prop.h is ready
Will be added via a deifferent branch
back to the way it was
Some explanations/comments edited.
added the lines for #define EXTRA_DISPLAY_CONTROLLER_INCLUDE
|
I am sure you are not going to like my indenting on this one. Everything is indented 4 spaces at a time. I have a version witch is all indented 2 spaces at a time but I find it a lot harder to read. I will upload the 2 spaces indentation version. Also, I would like to know how do you want me to write: and similar ? Thank you for your time. |
indented by 2 spaces, } else { fixed
Removed obsolete multipropdisplaycontroller information and code.
|
All indented with the "2 spaces" rule, I think I solved all the } else {. I hope you like it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just like my jetpack, it is not tested yet. Hopefully by the end March 2025, I will have a working saber to test it on.
Thanks in advance for an early review.
I initially added my multipropdisplaycontroller.h but I think it will be better in a separate PR (coming soon).