Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] chore: Frontend code refactoring #50

Open
wants to merge 66 commits into
base: main
Choose a base branch
from
Open

[WIP] chore: Frontend code refactoring #50

wants to merge 66 commits into from

Conversation

RoiArthurB
Copy link
Contributor

@RoiArthurB RoiArthurB commented Feb 7, 2025 •
edited
Loading

Pull Request

Checklist

  • Code is complete and ready for review
  • Tests have been added/updated (if applicable)
  • Documentation has been updated (if applicable)

Description

Refactoring all the code structure of v2 application to be easier to maintain, extend and develop.

Ping @GuillaumeLeroy34 tell me when this work is finished and ready to be merged :)

@GuillaumeLeroy34
refactor: Remove unused components and clean up code
574812d
@GuillaumeLeroy34
removed unused code, refactored a few component to not use the React.…
2c9628b 
…FC syntax anymore
@GuillaumeLeroy34
removed unused commented functions, fixed typos
21c14f1
@GuillaumeLeroy34
refactor: typo fixing, removed the React.FC and it's import from furt…
1598707 
…her components
@GuillaumeLeroy34
aspect: changed z-index of language & simulation selector: they shoul…
81bd7b1 
…d render properly when gama server cannot be reached
@GuillaumeLeroy34
removed unused code in the scan_and_connect zsh script
7ba21c8
@GuillaumeLeroy34
added a powershell script that's the windows equivalent of the scan_a…
173b1fa 
…nd_connect.zsh
@GuillaumeLeroy34
typo fix in VRHeadset
8e90131
@GuillaumeLeroy34
modified the script to enable it to accept external parameters
747f50d
@GuillaumeLeroy34
added jest for testing purposes
ffcac4d
@GuillaumeLeroy34
changed index and devicefinder to accept windows, and use the powersh…
11adf59 
…ell script
@GuillaumeLeroy34
modified the powershell script to correctly
226961a
@GuillaumeLeroy34
updated script to return errors to the backend
c405553
@GuillaumeLeroy34
slight cleanup of the css and general organisation of the html items
2406dac
@GuillaumeLeroy34
made the footer a component for better code legibility, and reused it…
d7f3a7f 
… where necessary
@GuillaumeLeroy34
Merge branch 'main' into windows_scrcpy_integration
848f9e6
@GuillaumeLeroy34
stash merging
e396a7a
@GuillaumeLeroy34
typo fixes, removed deprecated react.FC reference
33533cd
@GuillaumeLeroy34
Merged latest changes to scrcpy into windows_scrcpy_integration
3c7ff75
@GuillaumeLeroy34
merging stash
8695c2e
@GuillaumeLeroy34
removed unecessary variable, modified state hook for the buttons, add…
ae65c2d 
…ed debug text to check for display state
@GuillaumeLeroy34
Implementend a broadcast channel to enable the user to change the dis…
e626b74 
…play type of the tv screen
@GuillaumeLeroy34
removed unused display control panel page and it's references
5496277
@GuillaumeLeroy34
temporarily disabled uws.SHARED_COMPRESSOR to run the application wit…
7d75a1d 
…h unity
@GuillaumeLeroy34
removed unused constants, renamed broadcast channel from "sim" to 'si…
886f2cb 
…mulation-to-stream"
@GuillaumeLeroy34
added svg file
fade5e6
@GuillaumeLeroy34
first added player component
b0f11d5
@GuillaumeLeroy34
changes regarding the svg file
bfce148
@GuillaumeLeroy34
Merge branch 'windows_scrcpy_integration' into code_refactoring
a28b90f
@GuillaumeLeroy34
added svg files in a separate folder for better code readability in c…
2f6142e 
…omponents
@GuillaumeLeroy34
Modeled the header from the mockup
ad24f90
@GuillaumeLeroy34
moved svg folder to src
8d40457
@GuillaumeLeroy34
changed mentions of svg files, used header instead of separated navig…
d5f3ef8 
…ation & language selector
@GuillaumeLeroy34
fix to the main index page to ensure it takes up the whole page
1ccac52
@GuillaumeLeroy34
added a title, and added the related translation in english en french…
8120115 
…. viet and thai are required
@GuillaumeLeroy34
removed vestigial code and debug statements
11f8560
@GuillaumeLeroy34
removed code used to display players in the simulation selector as th…
637711a 
…is is handled elsewhere
@GuillaumeLeroy34
added the onclick property of english button that was missing for som…
d3b671c 
…e reason
@GuillaumeLeroy34
added translation, css cleanup, clicking outside translation popup to…
4d5ba3f 
… close it
@GuillaumeLeroy34
fixed typos and inconsistencies in naming convention
bab6ec9
@GuillaumeLeroy34
added visible player status, started reworking the player manager int…
f9e275b 
…erface
@GuillaumeLeroy34
added back strict mode to help ensure clean renders, removed provider
c7b8fab
@GuillaumeLeroy34
added an extra color to test headset coloring, removed useless comments
1c910e4
@GuillaumeLeroy34
changed cross color
9180451
@GuillaumeLeroy34
made the app display fit the dynamic view port, exactly 100% of it fi…
0143a65 
…ts now
@GuillaumeLeroy34
removed mentions of player connection related functions in the simula…
0f6a579 
…tion selection
@GuillaumeLeroy34
fixed × to close not displaying correctly
4b65a57
@GuillaumeLeroy34
added visible status of player, using connected and in_game properties
ff37b2a
@GuillaumeLeroy34
changed error to be more specific
e56e5de
@GuillaumeLeroy34
changed the headset status to fit all informations and control button…
2ccc738 
…s in one
@GuillaumeLeroy34
disabled status panel on vr headsets, minor visual and typo fixes
97e8919
@GuillaumeLeroy34
clicking inside does not close the window, added exit cross
567a2fe
@GuillaumeLeroy34
added translations for player status
8fedd08
@GuillaumeLeroy34
removed debug button
2e2562a
@GuillaumeLeroy34
added a new component to control streams from the tablet, changed rou…
cbf6121 
…te accordingly
@GuillaumeLeroy34
added display button, added extra states to the start simulation butt…
cf517d7 
…on for better feedback
@GuillaumeLeroy34
changed flex direction for better text and icon display
4474bbb
@GuillaumeLeroy34
added translation for simulation button clicked state
67b020c
@GuillaumeLeroy34
added new icon
1107fd6
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
5 Security Hotspots
3.1% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RoiArthurB @GuillaumeLeroy34