Add cluster name to the ordering to make sure that the data types always return in the same order every time for matter

[brdandu]

Github: ZAP #1596

[gemini-code-assist]

Summary of Changes

Hello @brdandu, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to resolve an issue where data types might not consistently return in the same order, particularly in contexts related to "matter" (likely a reference to the Matter smart home standard). By enhancing the database queries to sort data types not only by their name but also by their associated cluster name, the changes ensure a stable and predictable order of results, improving reliability for dependent operations.

Highlights

• Data Type Ordering Stability: Implemented changes across multiple database queries to ensure consistent and deterministic ordering of data types by incorporating the associated cluster name into the sorting criteria.
• Database Query Enhancements: Updated SQL queries for bitmap, enum, number, string, and struct data types to include LEFT JOIN operations with DATA_TYPE_CLUSTER and CLUSTER tables, enabling sorting by CLUSTER.NAME in addition to DATA_TYPE.NAME.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request aims to ensure a deterministic order for data type queries by adding the cluster name to the ORDER BY clause. The changes are consistently applied across several query files by joining DATA_TYPE_CLUSTER and CLUSTER tables. While reviewing, I noticed that in query-bitmap.js, the PACKAGE_REF column in the WHERE clause is ambiguous, unlike the other updated queries where it's properly qualified. I've added a suggestion to fix this for consistency and to prevent potential bugs.

[tecimovic]

Generally, functionality is fine.

I do have grave concerns about performance. Adding an INNER JOIN to the ORDER BY clause is very taxing on the performance of the SQLite, so we are slowly digging ourselves into the ground with this.... :(