Making sure delete endpoint happens before adding a new endpoint here

[brdandu]

JIRA: ZAPP-1672

[gemini-code-assist]

Summary of Changes

Hello @brdandu, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where endpoint deletion and addition operations might not execute in the correct sequence, leading to inconsistent state. It ensures that the deletion of an endpoint completes successfully before a new one is created by leveraging promise-based asynchronous control flow. Additionally, enhanced logging has been introduced to provide better visibility into endpoint attribute update requests.

Highlights

• Endpoint Deletion Sequence: Modified the deleteAndAddDeviceType method in ZclCreateModifyEndpoint.vue to ensure that an existing endpoint is fully deleted before a new one is added, preventing potential race conditions.
• Promise Chaining for Deletion: Updated the deleteEndpoint action in zap/actions.js to return a promise, enabling proper sequential execution and error handling in the UI component.
• Enhanced Logging: Added detailed warning-level logging for incoming request data within the httpPostAttributeUpdate function in user-data.js to aid in debugging endpoint attribute updates.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly addresses a race condition by ensuring an endpoint is deleted before a new one is created, using promise chaining. The changes to enable this in the Vuex action and the component are well-implemented. My review includes a suggestion to improve error handling propagation in the component and a note on some verbose logging that was added, which might be better suited for a debug level.

[gemini-code-assist]

This verbose logging of the entire request body at a warning level could be problematic in a production environment. It might expose sensitive user data in the logs and create unnecessary noise. For detailed debugging information like this, it's better to use a more appropriate log level, such as debug.

Suggested change

	env.logWarningToFile(`httpPostAttributeUpdate - Request data: endpointTypeIdList: ${JSON.stringify(endpointTypeIdList)},
	selectedEndpoint: ${selectedEndpoint},
	action: ${action},
	id: ${id},
	value: ${value},
	listType: ${listType},
	clusterRef: ${clusterRef},
	attributeSide: ${attributeSide},
	reportMinInterval: ${reportMinInterval},
	reportMaxInterval: ${reportMaxInterval},
	reportableChange: ${reportableChange}
	}`)
	env.logDebugToFile(`httpPostAttributeUpdate - Request data: endpointTypeIdList: ${JSON.stringify(endpointTypeIdList)},
	selectedEndpoint: ${selectedEndpoint},
	action: ${action},
	id: ${id},
	value: ${value},
	listType: ${listType},
	clusterRef: ${clusterRef},
	attributeSide: ${attributeSide},
	reportMinInterval: ${reportMinInterval},
	reportMaxInterval: ${reportMaxInterval},
	reportableChange: ${reportableChange}
	}`)