Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EverParse3d.InputStream.Base: do not use typeclasses for extra_t #117

Merged
merged 2 commits into from
Dec 4, 2023
Merged

EverParse3d.InputStream.Base: do not use typeclasses for extra_t #117

merged 2 commits into from
Dec 4, 2023

Commits on Dec 2, 2023

  1. nit: use instance val

    @mtzguido
    mtzguido committed Dec 2, 2023
    Configuration menu
    Copy the full SHA
    e82664f View commit details
    Browse the repository at this point in the history

  2. EverParse3d.InputStream.Base: do not use typeclasses for extra_t 

    This is not a class, and the recent changes to tcresolve will now
(rightfully) reject this. AFAICT, tcresolve was being used as a way
to solve this extra_t from the environment automatically, so we can do
just that, which is also likely much more efficient.
    @mtzguido
    mtzguido committed Dec 2, 2023
    Configuration menu
    Copy the full SHA
    7431735 View commit details
    Browse the repository at this point in the history