Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assorted build fixes. #123

Merged
merged 3 commits into from
Jan 22, 2024
Merged

Assorted build fixes. #123

merged 3 commits into from
Jan 22, 2024

Conversation

gebner
Copy link
Contributor

@gebner gebner commented Jan 18, 2024

We ran into this yesterday when discussing Everparse with Tahina.

  1. The makefile for the 3D modules tests failed to rebuild the test when you changed the 3d file.
  2. There were duplicate config.json files for the VS Code extension in the source tree. Particularly the one in src/3d was problematic, because it reset the include path. As a result, the extension did not work on fst files generated by the tests. (This change does not depend on Read configuration from make File.fst-in FStarLang/fstar-vscode-assistant#30 in any way.)

gebner and others added 3 commits January 18, 2024 10:57
@gebner
Fix incremental build.
46d2e72
@gebner
Remove redundant config.json files.
987823e 
This makes the VS Code extension work on generated files in src/3d/tests/modules.
@tahina-pro
Merge branch 'master' into buildfixes
3fe0156
@tahina-pro tahina-pro merged commit 00217c4 into project-everest:master Jan 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gebner @tahina-pro