Adapt to new elvis_core configuration validation
#72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+14
to
+15
| {elvis_core, | ||
| {git, "https://github.com/inaka/elvis_core.git", {branch, "fix/config-parse-validate"}}} |
Collaborator
Author
There was a problem hiding this comment.
elvis_core's linked pull request)
6 tasks
elbrujohalcon
approved these changes
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We tweak Rebar3 Lint, without changing its interface, to adapt to the most recent changes to
elvis_core, at inaka/elvis_core#515.elvis_corepull request resulted in a new version (it's possible until then we might need to keep implementing on top of this pull request, we'll see!)Further considerations
I expect CI to fail at least at the very end, since we're using a branch in a
rebar.configdep. and Elvis doesn't like it by default (or rather, per its configuration). ℹ️ as expected: https://github.com/project-fifo/rebar3_lint/pull/72/checks#step:7:46