Skip to content

Update client with v1beta2 protos #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2025
Merged

Update client with v1beta2 protos #55

merged 1 commit into from
May 8, 2025

Conversation

lennysgarage
Copy link
Contributor

@lennysgarage lennysgarage commented May 8, 2025

https://issues.redhat.com/browse/RHCLOUD-39359

Summary by Sourcery

New Features:

  • Introduce new v1beta2 proto files for Kessel inventory service

Signed-off-by: Jonathan Marcantonio <jmarcant@redhat.com>
Copy link

sourcery-ai bot commented May 8, 2025

Reviewer's Guide

This pull request integrates the v1beta2 protocol buffer definitions for the Kessel Inventory service. This is achieved through the addition of numerous new .proto files under kessel/inventory/v1beta2/, which collectively define the new API's service interface, request/response messages, and essential data structures.

File-Level Changes

Change Details Files
Introduction of v1beta2 proto definitions for Kessel Inventory API.
  • Defined new message types for API requests and responses (e.g., CheckForUpdateRequest, DeleteResourceResponse).
  • Established core data structures including references (e.g., ResourceReference, SubjectReference) and consistency mechanisms (ConsistencyToken).
  • Specified the InventoryService gRPC service, outlining its v1beta2 methods.
  • Included definitions for pagination (RequestPagination, ResponsePagination), metadata (RepresentationMetadata), and various enums.
src/main/proto/kessel/inventory/v1beta2/allowed.proto
src/main/proto/kessel/inventory/v1beta2/check_for_update_request.proto
src/main/proto/kessel/inventory/v1beta2/check_for_update_response.proto
src/main/proto/kessel/inventory/v1beta2/check_request.proto
src/main/proto/kessel/inventory/v1beta2/check_response.proto
src/main/proto/kessel/inventory/v1beta2/consistency.proto
src/main/proto/kessel/inventory/v1beta2/consistency_token.proto
src/main/proto/kessel/inventory/v1beta2/delete_resource_request.proto
src/main/proto/kessel/inventory/v1beta2/delete_resource_response.proto
src/main/proto/kessel/inventory/v1beta2/inventory_service.proto
src/main/proto/kessel/inventory/v1beta2/report_resource_request.proto
src/main/proto/kessel/inventory/v1beta2/report_resource_response.proto
src/main/proto/kessel/inventory/v1beta2/reporter_reference.proto
src/main/proto/kessel/inventory/v1beta2/representation_metadata.proto
src/main/proto/kessel/inventory/v1beta2/representation_type.proto
src/main/proto/kessel/inventory/v1beta2/request_pagination.proto
src/main/proto/kessel/inventory/v1beta2/resource_reference.proto
src/main/proto/kessel/inventory/v1beta2/resource_representations.proto
src/main/proto/kessel/inventory/v1beta2/response_pagination.proto
src/main/proto/kessel/inventory/v1beta2/streamed_list_objects_request.proto
src/main/proto/kessel/inventory/v1beta2/streamed_list_objects_response.proto
src/main/proto/kessel/inventory/v1beta2/subject_reference.proto
src/main/proto/kessel/inventory/v1beta2/write_visibility.proto

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lennysgarage - I've reviewed your changes - here's some feedback:

  • Ensure these new v1beta2 proto files are integrated into the build process for code generation.
  • The PR title suggests client application updates using these new protos; consider including those changes here or clarifying if they are planned for a separate PR.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@lennysgarage lennysgarage merged commit 458b8e6 into main May 8, 2025
1 check passed
@lennysgarage lennysgarage deleted the v1beta2-protos branch May 8, 2025 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant