-
Notifications
You must be signed in to change notification settings - Fork 2
Update client with v1beta2 protos #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Jonathan Marcantonio <jmarcant@redhat.com>
Reviewer's GuideThis pull request integrates the v1beta2 protocol buffer definitions for the Kessel Inventory service. This is achieved through the addition of numerous new File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @lennysgarage - I've reviewed your changes - here's some feedback:
- Ensure these new v1beta2 proto files are integrated into the build process for code generation.
- The PR title suggests client application updates using these new protos; consider including those changes here or clarifying if they are planned for a separate PR.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
https://issues.redhat.com/browse/RHCLOUD-39359
Summary by Sourcery
New Features: