-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[COST-4407] Add service account support #471
Conversation
Codecov Report
@@ Coverage Diff @@
## main #471 +/- ##
=======================================
- Coverage 93.5% 93.5% -0.1%
=======================================
Files 60 60
Lines 4603 4620 +17
Branches 660 662 +2
=======================================
+ Hits 4306 4319 +13
- Misses 156 157 +1
- Partials 141 144 +3 |
12f80f5
to
7ae475b
Compare
testing instructions look good to me, seeing logs in listener:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, one nitpick is to update the version number
618979e
to
0df046e
Compare
* Add service account support as basic auth is becoming EOL
0df046e
to
3a21df9
Compare
I've updated the version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍🏾
Test
In order to test checkout the branch.
make install
HCC_SERVICE_ACCOUNT_ID
,HCC_SERVICE_ACCOUNT_SECRET
, andHCC_TOKEN_URL
(depending on your environmentnise report ocp --insights-upload https://console.redhat.com/api/ingress/v1/upload -s 2023-11-01 --ocp-cluster-id my-test-upload