Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix datetime in local GCP flow #473

Merged
merged 2 commits into from
Nov 6, 2023
Merged

Fix datetime in local GCP flow #473

merged 2 commits into from
Nov 6, 2023

Conversation

esebesto
Copy link
Contributor

@esebesto esebesto commented Nov 3, 2023

PR https://github.com/project-koku/nise/pull/470/files broke local GCP flow.
Changes in this PR should hopefully work for both local and non-local flow.

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #473 (abc4507) into main (f6cd14e) will decrease coverage by 0.0%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##            main    #473     +/-   ##
=======================================
- Coverage   93.5%   93.5%   -0.0%     
=======================================
  Files         60      60             
  Lines       4603    4603             
  Branches     660     660             
=======================================
- Hits        4304    4303      -1     
  Misses       157     157             
- Partials     142     143      +1     

@esebesto esebesto merged commit 4f82260 into main Nov 6, 2023
4 checks passed
@esebesto esebesto deleted the esebesto/fix_local_gcp branch November 6, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants