Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COST-4367] Allow legal entity setting for AWS and fix date issue #481

Merged
merged 3 commits into from
Dec 6, 2023

Conversation

cgoodfred
Copy link
Contributor

To account for all of the HCS use cases, the legal entity should be settable for AWS generators. This also addresses a datetime.date issue where tzinfo is not an attribute on date objects, only datetime objects.

@cgoodfred cgoodfred self-assigned this Dec 6, 2023
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Merging #481 (2591f1c) into main (d15b7ef) will increase coverage by 0.1%.
The diff coverage is 100.0%.

Additional details and impacted files
@@           Coverage Diff           @@
##            main    #481     +/-   ##
=======================================
+ Coverage   93.5%   93.6%   +0.1%     
=======================================
  Files         60      60             
  Lines       4625    4629      +4     
  Branches     663     664      +1     
=======================================
+ Hits        4324    4331      +7     
+ Misses       157     156      -1     
+ Partials     144     142      -2     

@cgoodfred cgoodfred marked this pull request as ready for review December 6, 2023 18:21
@cgoodfred cgoodfred merged commit df94dd6 into main Dec 6, 2023
4 checks passed
@cgoodfred cgoodfred deleted the COST-4367-HCS-CCSP-AWS branch December 6, 2023 18:24
@esebesto esebesto mentioned this pull request Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants