Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove blanks at location which might cause errors when reading csv with LibreOffice #482

Merged
merged 2 commits into from
Jan 11, 2024

Conversation

pedrolp85
Copy link
Contributor

@pedrolp85 pedrolp85 commented Jan 11, 2024

The blanks at the end of the Data transfer location generator causes that Libreoffice read it as a tab,
In the case we want to modify the .csv (for example removing a column), the files with that location are shifted one column to the right:

Before:

grep -A 1 -B 1 -i "mumbai" January-2024-vMnAylnn.csv

,"Amazon Web Services, Inc.",$20.0 per GB - Asia Pacific (Mumbai) data transfer to Asia Pacific (Mumbai) ,

After:
,"Amazon Web Services, Inc.",$20.0 per GB - Asia Pacific (Mumbai) data transfer to Asia Pacific (Mumbai),

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

Merging #482 (e583934) into main (aff72e6) will decrease coverage by 0.0%.
Report is 3 commits behind head on main.
The diff coverage is 100.0%.

Additional details and impacted files
@@           Coverage Diff           @@
##            main    #482     +/-   ##
=======================================
- Coverage   93.5%   93.5%   -0.0%     
=======================================
  Files         60      60             
  Lines       4620    4629      +9     
  Branches     662     664      +2     
=======================================
+ Hits        4321    4328      +7     
- Misses       156     157      +1     
- Partials     143     144      +1     

@pedrolp85 pedrolp85 changed the title remove blanks at location which might cause errors when reading csv with pandas remove blanks at location which might cause errors when reading csv with LibreOffice Jan 11, 2024
@pedrolp85 pedrolp85 merged commit d778a8d into main Jan 11, 2024
4 checks passed
@pedrolp85 pedrolp85 deleted the plopezpe/remove_tab_in_location_strings branch January 11, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants