NCL-8780 Unify empty table header to use aria-label

project-ncl · Aug 22, 2024 · db83fed · db83fed
1 parent 06fa3f2
commit db83fed
Show file tree

Hide file tree

Showing 7 changed files with 9 additions and 7 deletions.
diff --git a/src/components/ArtifactsList/ArtifactsList.tsx b/src/components/ArtifactsList/ArtifactsList.tsx
@@ -190,7 +190,7 @@ export const ArtifactsList = ({ serviceContainerArtifacts, columns = defaultColu
                   }}
                   aria-label="Expand all"
                 />
-                {columns.includes(artifactEntityAttributes.build.id) && <Th width={10} />}
+                {columns.includes(artifactEntityAttributes.build.id) && <Th width={10} aria-label="Build Icon" />}
                 {columns.includes(artifactEntityAttributes.identifier.id) && (
                   <Th width={30} sort={getSortParams(sortOptions.sortAttributes['identifier'].id)}>
                     {artifactEntityAttributes.identifier.title}

diff --git a/src/components/ArtifactsPage/__tests__/__snapshots__/ArtifactsPage.test.tsx.snap b/src/components/ArtifactsPage/__tests__/__snapshots__/ArtifactsPage.test.tsx.snap
@@ -304,6 +304,7 @@ Object {
                     </button>
                   </th>
                   <th
+                    aria-label="Build Icon"
                     class="pf-v5-c-table__th pf-m-width-10"
                     scope="col"
                     tabindex="-1"
@@ -1320,6 +1321,7 @@ Object {
                   </button>
                 </th>
                 <th
+                  aria-label="Build Icon"
                   class="pf-v5-c-table__th pf-m-width-10"
                   scope="col"
                   tabindex="-1"

diff --git a/src/components/ConfigsEditList/ConfigsAddList.tsx b/src/components/ConfigsEditList/ConfigsAddList.tsx
@@ -188,7 +188,7 @@ export const ConfigsAddList = <T extends BuildConfiguration | GroupConfiguration
                     {buildConfigEntityAttributes['project.name'].title}
                   </Th>
                 )}
-                <Th screenReaderText="Actions" />
+                <Th aria-label="Actions" />
               </Tr>
             </Thead>
             <Tbody>

diff --git a/src/components/ConfigsEditList/ConfigsChangesList.tsx b/src/components/ConfigsEditList/ConfigsChangesList.tsx
@@ -42,10 +42,10 @@ export const ConfigsChangesList = <T extends BuildConfiguration | GroupConfigura
           <Table isStriped variant="compact">
             <Thead>
               <Tr>
-                <Th screenReaderText="Added or removed icon" />
+                <Th aria-label="Added or removed icon" />
                 <Th width={60}>{buildConfigEntityAttributes.name.title}</Th>
                 {variant === 'Build' && <Th width={40}>{buildConfigEntityAttributes['project.name'].title}</Th>}
-                <Th screenReaderText="Actions" />
+                <Th aria-label="Actions" />
               </Tr>
             </Thead>
             <Tbody>

diff --git a/src/components/ConfigsEditList/ConfigsRemoveList.tsx b/src/components/ConfigsEditList/ConfigsRemoveList.tsx
@@ -156,7 +156,7 @@ export const ConfigsRemoveList = <T extends BuildConfiguration | GroupConfigurat
                     {buildConfigEntityAttributes['project.name'].title}
                   </Th>
                 )}
-                <Th screenReaderText="Actions" />
+                <Th aria-label="Actions" />
               </Tr>
             </Thead>
             <Tbody>

diff --git a/src/components/ProductVersionMilestonesList/ProductVersionMilestonesList.tsx b/src/components/ProductVersionMilestonesList/ProductVersionMilestonesList.tsx
@@ -100,7 +100,7 @@ export const ProductVersionMilestonesList = ({
                 <Th width={15} sort={getSortParams(sortOptions.sortAttributes.endDate.id)}>
                   {productMilestoneEntityAttributes.endDate.title}
                 </Th>
-                <Th screenReaderText="Actions" />
+                <Th aria-label="Actions" />
               </Tr>
             </Thead>
             <Tbody>

diff --git a/src/components/ProductVersionReleasesList/ProductVersionReleasesList.tsx b/src/components/ProductVersionReleasesList/ProductVersionReleasesList.tsx
@@ -81,7 +81,7 @@ export const ProductVersionReleasesList = ({
                 <Th width={20} sort={getSortParams(sortOptions.sortAttributes.supportLevel.id)}>
                   {productReleaseEntityAttributes.supportLevel.title}
                 </Th>
-                <Th screenReaderText="Actions" />
+                <Th aria-label="Actions" />
               </Tr>
             </Thead>
             <Tbody>