Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NCL-7898] Refactor useForm to add boolean value for preBuildSyncEnable #249

Merged
merged 2 commits into from
Jul 11, 2023

Conversation

DnsZhou
Copy link
Contributor

@DnsZhou DnsZhou commented Jul 5, 2023

No description provided.

@matedo1 matedo1 removed their request for review July 5, 2023 10:07
@DnsZhou
Copy link
Contributor Author

DnsZhou commented Jul 5, 2023

Known issue: there is an uncaught type error with patch requests in useForm hook, e.g., edit scmRepository scenario or edit projects. But the patch request itself finished properly.
image

NCL-8006 Created for this issue

src/hooks/useForm.ts Outdated Show resolved Hide resolved
src/utils/patchHelper.ts Outdated Show resolved Hide resolved
src/hooks/useServiceContainer.ts Outdated Show resolved Hide resolved
@DnsZhou DnsZhou requested a review from patrikk0123 July 10, 2023 18:52
@DnsZhou DnsZhou merged commit 81974d4 into project-ncl:main Jul 11, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants