Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NCL-7219] Artifact detail page #252

Merged
merged 6 commits into from
Jul 27, 2023

Conversation

patrikk0123
Copy link
Contributor

No description provided.

@patrikk0123 patrikk0123 changed the title [NCL-7219] artifact detail page [NCL-7219] Artifact detail page Jul 12, 2023
@matedo1 matedo1 removed their request for review July 13, 2023 10:28
Copy link
Contributor

@DnsZhou DnsZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @patrikk0123 , Thanks for finishing the task rapidly, I can the commit was even submitted before our planning meeting. The UI looks good and no console errors, just some small issues to be considered. Thanks!

src/components/ArtifactDetailPage/ArtifactDetailPage.tsx Outdated Show resolved Hide resolved
src/components/ArtifactDetailPage/ArtifactDetailPage.tsx Outdated Show resolved Hide resolved
src/components/ArtifactDetailPage/ArtifactDetailPage.tsx Outdated Show resolved Hide resolved
src/utils/utils.ts Outdated Show resolved Hide resolved
src/components/DownloadLink/DownloadLink.tsx Outdated Show resolved Hide resolved
src/components/ArtifactDetailPage/ArtifactDetailPage.tsx Outdated Show resolved Hide resolved
src/components/DownloadLink/DownloadLink.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@DnsZhou DnsZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All points above have been verified from my local env, Thanks!

@patrikk0123 patrikk0123 merged commit 643d5ac into project-ncl:main Jul 27, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants