Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NCL-8835] Fix Log Viewer scrolling issues #585

Merged
merged 3 commits into from
Oct 10, 2024
Merged

[NCL-8835] Fix Log Viewer scrolling issues #585

merged 3 commits into from
Oct 10, 2024

Conversation

patrikk0123
Copy link
Contributor

No description provided.

@matedo1 matedo1 requested review from DnsZhou and removed request for matedo1 October 8, 2024 16:57
@matedo1
Copy link
Contributor

matedo1 commented Oct 8, 2024

Hi @DnsZhou , see also the latest comments in NCL-8835

@DnsZhou DnsZhou mentioned this pull request Oct 10, 2024
Merged
DnsZhou
DnsZhou approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@DnsZhou DnsZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified from my local that top/bottom button are fixed, force following is also working well now. New layout looks good to me. just some TS docs please.

src/components/AlignmentLogLink/AlignmentLogLink.tsx Show resolved Hide resolved
@patrikk0123 patrikk0123 merged commit 6c84c35 into project-ncl:main Oct 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DnsZhou DnsZhou DnsZhou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@patrikk0123 @matedo1 @DnsZhou