Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resurrect nogui executable #318

Open
wants to merge 11 commits into
base: slippi
Choose a base branch
from
Open

Conversation

vladfi1
Copy link
Contributor

@vladfi1 vladfi1 commented Sep 21, 2021

Also allows building headless, which is useful for bots.

@@ -276,7 +276,7 @@ void SlippiUser::FileListenThread()
if (AttemptLogin())
{
runThread = false;
main_frame->RaiseRenderWindow();
// main_frame->RaiseRenderWindow();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

macOS still uses this, just fyi - so maybe instead of commenting it out just block it off with an #ifdef __APPLE_.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue is that the nogui build will still fail since we don't compile DolphinWX at all in nogui.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I have an idea for a fix...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, sure - #ifndef NOGUI or whatever on the imports and raise/lower calls would suffice, no?

@vladfi1
Copy link
Contributor Author

vladfi1 commented Sep 22, 2021

So I need to fix the dependencies on DolphinWX which are currently just commented out (and are likely resulting in all the build failure).

  1. SlippiTimer.cpp: maybe I can just move it into DolphinWX? Need to check where it is actually used.
  2. main_frame->Raise/LowerRenderWindow: The issue is that DolphinWX won't exist in the nogui build. Cleanest thing to do here might be to set define NOGUI and then block those parts off with an #ifndef NOGUI.

@vladfi1
Copy link
Contributor Author

vladfi1 commented Sep 22, 2021

  1. main_frame->Raise/LowerRenderWindow: The issue is that DolphinWX won't exist in the nogui build. Cleanest thing to do here might be to set define NOGUI and then block those parts off with an #ifndef NOGUI.

Actually this won't work because SlippiLib is built independently of gui/nogui. As a workaround I've added a fix for this with some stub functions in UICommon.h that are implemented in either DolphinWX or DophinNoGui.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants