-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resurrect nogui executable #318
base: slippi
Are you sure you want to change the base?
Conversation
@@ -276,7 +276,7 @@ void SlippiUser::FileListenThread() | |||
if (AttemptLogin()) | |||
{ | |||
runThread = false; | |||
main_frame->RaiseRenderWindow(); | |||
// main_frame->RaiseRenderWindow(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
macOS still uses this, just fyi - so maybe instead of commenting it out just block it off with an #ifdef __APPLE_
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue is that the nogui build will still fail since we don't compile DolphinWX at all in nogui.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I have an idea for a fix...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, sure - #ifndef NOGUI
or whatever on the imports and raise/lower calls would suffice, no?
So I need to fix the dependencies on DolphinWX which are currently just commented out (and are likely resulting in all the build failure).
|
Actually this won't work because SlippiLib is built independently of gui/nogui. As a workaround I've added a fix for this with some stub functions in |
b0868c6
to
aaad1a2
Compare
6d4c8d0
to
3058c40
Compare
64dfeec
to
6c4be50
Compare
Also allows building headless, which is useful for bots.