Skip to content

Removed unit tests of type "INTERVAL". #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

kcc-oniki
Copy link
Contributor

dev/timezoneブランチをベースに、INTERVAL型に関係する不要コードおよびテストを全て削除しました。
また、互換用の簡易テストコードも修正しました。

レグレッションテスト結果

JSON版

postgres@ubuntu22040:build.json$ cmake -G Ninja -DCMAKE_BUILD_TYPE=Debug -DDATA_STORAGE=json ..
-- The CXX compiler identification is GNU 11.4.0
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found Doxygen: /usr/bin/doxygen (found version "1.9.1") found components: doxygen missing components: dot
-- Found Boost: /usr/lib/x86_64-linux-gnu/cmake/Boost-1.74.0/BoostConfig.cmake (found version "1.74.0") found components: system filesystem
-- The target of the build is metadata-manager.
--   Default log output level for metadata-manager is ERROR.
--   Metadata is stored in JSON-file.
--   Exclude postgresql sources.
--   Exclude postgresql test sources.
-- The C compiler identification is GNU 11.4.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Looking for pthread.h
-- Looking for pthread.h - found
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE
-- Configuring done
-- Generating done
-- Build files have been written to: /home/postgres/.local/src/metadata-manager/build.json
postgres@ubuntu2204:build.json$ ninja && (sleep 0.2; ctest)
[66/66] Linking CXX executable test/src/metadata_test
Test project /home/postgres/.local/src/metadata-manager/build.json
    Start 1: test
1/1 Test #1: test .............................   Passed    1.54 sec

100% tests passed, 0 tests failed out of 1

Total Test time (real) =   1.54 sec
postgres@ubuntu22040:build.json$ ../test/extended/json/expected/test_tables.sh tables_test
-----------------------------------------------------------------------
[OID file]
Succeed: There is no difference.
-----------------------------------------------------------------------
[Tables metadata]
Succeed: There is no difference.
-----------------------------------------------------------------------
[Test result]
Succeed: There is no difference.

PostgreSQL版

postgres@ubuntu22040:build.pg$ cmake -G Ninja -DCMAKE_BUILD_TYPE=Debug -DDATA_STORAGE=postgresql ..
-- The CXX compiler identification is GNU 11.4.0
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found Doxygen: /usr/bin/doxygen (found version "1.9.1") found components: doxygen missing components: dot
-- Found Boost: /usr/lib/x86_64-linux-gnu/cmake/Boost-1.74.0/BoostConfig.cmake (found version "1.74.0") found components: system filesystem
-- Found pg_config for PostgreSQL: /home/postgres/.local/pgsql/current/bin/pg_config
--   Header file directory: /home/postgres/.local/pgsql/15/include
--   Library file directory: /home/postgres/.local/pgsql/15/lib
-- The target of the build is metadata-manager.
--   Default log output level for metadata-manager is ERROR.
--   Metadata is stored in PostgreSQL.
--   Exclude json sources.
--   Exclude json test sources.
-- The C compiler identification is GNU 11.4.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Looking for pthread.h
-- Looking for pthread.h - found
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE
-- Configuring done
-- Generating done
-- Build files have been written to: /home/postgres/.local/src/metadata-manager/build.pg
postgres@ubuntu2204:build.pg$ ninja && (sleep 0.2; ctest)
[77/77] Linking CXX executable test/src/metadata_test
Test project /home/postgres/.local/src/metadata-manager/build.pg
    Start 1: test
1/1 Test #1: test .............................   Passed   16.46 sec

100% tests passed, 0 tests failed out of 1

Total Test time (real) =  16.46 sec

@kcc-oniki kcc-oniki requested a review from fujita-kin August 13, 2024 06:22
@kcc-oniki kcc-oniki requested a review from koh-okada as a code owner August 13, 2024 06:22
@fujita-kin fujita-kin merged commit 2b094e9 into dev/timezone Aug 20, 2024
2 checks passed
@kcc-oniki kcc-oniki deleted the dev/timezone_test_fix branch August 20, 2024 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants