Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated stories structure to be in respective component itself #511

Merged
merged 3 commits into from
Nov 28, 2023

Conversation

vivek-p44
Copy link
Collaborator

Closes # https://project44.atlassian.net/browse/MI-27

📝 Description

Updated stories structure so that they can be component's folder itself, so that it becomes easy and obvious to have 1:1 mapping for stories with component.

Screenshots

Please provide screenshots for any visual changes

Merge checklist

  • Added/updated tests
  • Added changeset

@vivek-p44 vivek-p44 requested a review from a team as a code owner November 23, 2023 05:12
Copy link

changeset-bot bot commented Nov 23, 2023

🦋 Changeset detected

Latest commit: 7829d17

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@project44-manifest/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vitaliy-p44
Copy link
Contributor

Can we put story files right into the component's folders? It doesn't make sense to have an extra directory there for a single story file.

@vivek-p44 vivek-p44 self-assigned this Nov 23, 2023
@vivek-p44
Copy link
Collaborator Author

vivek-p44 commented Nov 23, 2023

Can we put story files right into the component's folders? It doesn't make sense to have an extra directory there for a single story file.

We are planning to move all the files related to a component in component itself, so it make it easier to find out things I have placed things under directory. will be adding test as well under component itself. will move subcomponent as well inside.

- Component
  - story
  - tests
  - component

This is the structure we want to keep.

@vivek-p44 vivek-p44 merged commit 6b70e3d into main Nov 28, 2023
@vivek-p44 vivek-p44 deleted the MI-27 branch November 28, 2023 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants