module design for vioapic #8741
Conversation
Move the closing markers in the '#define .. #endif' to match the opening markers. Tracked-On: projectacrn#8665 Signed-off-by: Haiwei Li <haiwei.li@intel.com>
This patch is to: * Trim trailing whitespaces * Use macro and add comments * Add lock around `reset_one_vioapic()` Tracked-On: projectacrn#8740 Signed-off-by: Haiwei Li <haiwei.li@intel.com>
haiwei-li
requested review from
dongyaozu,
lifeix and
junjiemao1
as code owners
|
@shiqingg pls help to review. Thanks! |
|
@haiwei-li ， hypervisor/build/dm/vioapic.o |
GAI Tooling Notice: These contents may have been developed with support from one or more generative artificial intelligence solutions. This patch is to add doxygen style comments for some elements in vp-dm_vioapic module. Tracked-On: projectacrn#8665 Signed-off-by: Haiwei Li <haiwei.li@intel.com>
| #define RTBL_RO_BITS ((uint32_t)0x00004000U | (uint32_t)0x00001000U) /*Remote IRR and Delivery Status bits*/ | ||
|
|
||
| #define DBG_LEVEL_VIOAPIC 6U | ||
| #define ACRN_IOAPIC_VERSION 0x11U | ||
|
|
||
| /** | ||
| * @brief The default definition of a RTE. |
There was a problem hiding this comment.
default value of a virtual RTE ?
| * And for every virtual I/O APIC: | ||
| * - Per spec, it initializes every redirection table entry (RTE) to the default value which is 0x0001000000000000. And | ||
| * it masks the interrupt by setting the 'mask' (bit 16). | ||
| * - It registers the MMIO emulation handler for all the registers and remove the EPT mapping for the registers address |
There was a problem hiding this comment.
Explicitly call out the handler vioapic_mmio_access_handler?
| * | ||
| * @return None | ||
| * | ||
| * @pre vm != NULL | ||
| * @pre vm->arch_vm.vioapics != NULL |
There was a problem hiding this comment.
vm->arch_vm.vioapics is not a pointer
| @@ -120,5 +143,6 @@ struct acrn_single_vioapic *vgsi_to_vioapic_and_vpin(const struct acrn_vm *vm, u | |||
| /** | |||
| * @} | |||
| */ | |||
|
|
|||
There was a problem hiding this comment.
Pls help remove the out-of-date documentation of vioapic_set_irqline_lock and vioapic_set_irqline_nolock in vioapic.h. Thanks.
| reset_one_vioapic(&vioapics->vioapic_array[vioapic_index]); | ||
| spinlock_irqrestore_release(&(vioapics->vioapic_array[vioapic_index].lock), rflags); |
There was a problem hiding this comment.
Pls create a separate PR for this lock change. Thanks.
No description provided.