sanitizeEnv.sh update
#132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the sanitizeEnv.sh script to improve cross-platform compatibility and address shellcheck warnings. The changes add support for BSD sed (macOS), fix printf formatting issues, and gracefully handle missing files.
Key Changes:
- Added OS detection to support both GNU and BSD
sedsyntax - Fixed
printfstatements to properly format color codes using format specifiers - Added file existence check to prevent errors when sanitizing non-existent files
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This changes the code to handle running with either GNU or BSD `sed`. macOS uses BSD `sed`, which expect an argument to be passed to `-i` unlike GNU `sed` which does not.
SC2059 'Don't use variables in the printf format string. Use printf '..%s..' "$foo"'
Prevent special characters from causing issues in the `sed` replacements.
rustydb
force-pushed
the
sanitize-update
branch
from
70049d6 to
4f97875
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used the
sanitizeEnv.shscript, made some changes:sedprintfshellcheck fixThe script isn't executable and is missing a shebang, wasn't sure if there was a reason for that or not.