Adjust css of masonry view so keyboard navigation works and links are visible on focus #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoyne
approved these changes
Dec 10, 2024
… visible on focus
corylown
force-pushed
the
masonry-keyboard-nav
branch
from
b11cfa9 to
aa22136
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously none of the results were keyboard navigable in masonry view because the linked title was set to
display: noneand the linked thumbnails havetabindex=-1. This adjust the CSS so the linked titles are hidden from view but present in the DOM and navigable by keyboard. The title displays when hovering over the thumbnail or when the title area gets focus.