Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test App fixup for BL8 only needed prior to 8.7.0 #309

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Test App fixup for BL8 only needed prior to 8.7.0 #309

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions spec/test_app_templates/lib/generators/test_app_generator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,13 @@ def run_bl7_jsbundling_fixup
end

def run_bl8_jsbundling_fixup
# while it's named confusingly, the BL8 assets:propshaft generator has what we need
# for jsbundling, I think.
if File.exist?("package.json") && Blacklight::VERSION.split(".").first == "8"
# BL 8.7.0 doesn't seem to need anything, but BL8 before that the automatic BL
# install process doesn't do everything we need.
#
# By manually triggering the BL8 assets:propshaft generator, we can get what we need
# for jsbundling, even though it's named confusingly for that, it works in these
# versions.
if File.exist?("package.json") && Gem::Requirement.create("~> 8.0", "< 8.7.0").satisfied_by?(Gem::Version.new(Blacklight::VERSION))
generate "blacklight:assets:propshaft"
end
end
Expand Down
Loading