Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and use input field components for range form. #313

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dkinzer
Copy link
Member

@dkinzer dkinzer commented Feb 7, 2025

REF: #312

@jrochkind
Copy link
Member

Ah, I see you already have gotten to it.

What do you think about adding a configuration field for the input_component, so local apps can change it and have it picked up by the advanced search plugin?

What tests should we add to ensure the hook you need in advanced search from remains without breaking, perhaps with comments warning that this is API used by external dependents?

@jrochkind
Copy link
Member

The test failure looks familiar, this is something that's been happening to other projects, perhaps updating Rails version to latest patch release would fix it, I forget.

@seanaery
Copy link
Collaborator

Yes, the test failure is this; it's happening in the Rails 7.0 cell and is due to an internal Rails bug that isn't going to get fixed given that 7.0 is no longer under active support. Workarounds are challenging and/or undesirable, e.g., pinning "concurrent-ruby", "< 1.3.5". The solution at the Blacklight core level was to remove any Rails versions under 7.1 from the CI matrix. Seems like we should we do the same here in blacklight_range_limit.

@jrochkind
Copy link
Member

Thanks!

I think pinning concurrent-ruby to < 1.3.5 for test matrixes with Rails less than 7.1 is the way to go.

I'll try to do a PR to do that separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants