Skip to content

Conversation

@nelljerram
Copy link
Member

No description provided.

@nelljerram nelljerram requested a review from a team as a code owner November 12, 2025 11:55
Copilot AI review requested due to automatic review settings November 12, 2025 11:55
@marvin-tigera marvin-tigera added this to the Calico v3.32.0 milestone Nov 12, 2025
@marvin-tigera marvin-tigera added release-note-required Change has user-facing impact (no matter how small) docs-pr-required Change is not yet documented labels Nov 12, 2025
@nelljerram nelljerram added docs-not-required Docs not required for this change release-note-not-required Change has no user-facing impact and removed release-note-required Change has user-facing impact (no matter how small) docs-pr-required Change is not yet documented labels Nov 12, 2025
Copilot finished reviewing on behalf of nelljerram November 12, 2025 11:58
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors OpenStack branch inference by introducing a new script infer-openstack-branch.sh that dynamically determines the correct DevStack branch based on the OpenStack release name. This eliminates the need for hardcoded branch mappings and makes the system more maintainable as OpenStack releases transition between stable/* and unmaintained/* branches.

Key changes:

  • New infer-openstack-branch.sh script that queries GitHub to find the correct branch prefix for a given OpenStack release
  • Updated bootstrap.sh to use OPENSTACK_RELEASE environment variable instead of DEVSTACK_BRANCH
  • Simplified constraints file handling with dynamic branch resolution

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
networking-calico/infer-openstack-branch.sh New script that infers the correct branch (stable/* or unmaintained/*) for OpenStack releases by querying GitHub
networking-calico/devstack/bootstrap.sh Refactored to use OPENSTACK_RELEASE and call the new inference script; simplified constraints URL construction
networking-calico/Makefile Updated caracal constraints target to use the inference script for dynamic branch resolution
.semaphore/semaphore.yml.d/blocks/40-openstack.yml Changed from DEVSTACK_BRANCH to OPENSTACK_RELEASE for yoga and caracal test configurations
.semaphore/semaphore.yml Generated file updated to reflect the changes in the source blocks
.semaphore/semaphore-scheduled-builds.yml Generated file updated to reflect the changes in the source blocks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs-not-required Docs not required for this change release-note-not-required Change has no user-facing impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants