Remove HostMetadata and HostMetadataV6 protobuf messages, consolidate to HostMetadataV4V6 #11441
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Consolidates three redundant host metadata protobuf message variants (
HostMetadata,HostMetadataV6,HostMetadataV4V6) into a singleHostMetadataV4V6type that carries both IPv4 and IPv6 addresses along with AS number and labels.Changes:
HostMetadataUpdate,HostMetadataRemove,HostMetadataV6Update,HostMetadataV6Removemessages fromfelixbackend.protoOnHostIPUpdate,OnHostIPRemove,OnHostIPv6Update,OnHostIPv6Remove) and pending state maps fromEventSequencer; removedHostIPKeyregistration fromDataplanePassthrunoencap_mgr,wireguard_mgr,ipip_mgr,bpf_ep_mgrto handle onlyHostMetadataV4V6Update/HostMetadataV4V6Removewith IP version filteringComponents affected: felix/calc, felix/proto, felix/dataplane
Related issues/PRs
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.