Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helm): don't render capsuleconfiguration if crds.exclusive is set #1148

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

MaxFedotov
Copy link
Collaborator

closes #1147

Copy link

netlify bot commented Aug 1, 2024

Deploy Preview for capsule-documentation canceled.

Name Link
🔨 Latest commit 6b38fec
🔍 Latest deploy log https://app.netlify.com/sites/capsule-documentation/deploys/66abae65821c950009e9c610

Copy link
Member

@prometherion prometherion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely a bug, LGTM but please, address the CI complaints before getting it merged.

Signed-off-by: Max Fedotov <m.a.fedotov@gmail.com>
@MaxFedotov MaxFedotov changed the title fix(helm): don't render CapsuleConfiguration if crds.exclusive is set fix(helm): don't render capsuleconfiguration if crds.exclusive is set Aug 1, 2024
@MaxFedotov MaxFedotov self-assigned this Aug 1, 2024
@MaxFedotov MaxFedotov merged commit 8930090 into projectcapsule:main Aug 1, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default capsuleConfiguration is rendered in helm chart when setting crds.exclusive=true
2 participants