Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve changelog documentation and linting #845

Merged
merged 6 commits into from
Oct 24, 2023
Merged

feat: improve changelog documentation and linting #845

merged 6 commits into from
Oct 24, 2023

Conversation

oliverbaehler
Copy link
Collaborator

@oliverbaehler oliverbaehler commented Oct 23, 2023

Adds a lot of documentation, references changelog to where it's created. Ensures commits are formatted to or changelog's standards. The biggest dicussion point here, is regarding the types of changes and their scope which we accept. Most of the other changes are based on the ruleset.

Let me know what you think:

https://github.com/buttahtoast/capsule-cncf-slam/blob/feat/doc-changelog/CONTRIBUTING.md#semantics

Signed-off-by: Oliver Bähler <oliverbaehler@hotmail.com>
Signed-off-by: Oliver Bähler <oliverbaehler@hotmail.com>
Signed-off-by: Oliver Bähler <oliverbaehler@hotmail.com>
Signed-off-by: Oliver Bähler <oliverbaehler@hotmail.com>
Signed-off-by: Oliver Bähler <oliverbaehler@hotmail.com>
@oliverbaehler oliverbaehler changed the title draft: improve changelog documentation and linting feat: improve changelog documentation and linting Oct 23, 2023
Signed-off-by: Oliver Bähler <oliverbaehler@hotmail.com>
Copy link
Member

@prometherion prometherion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Terrific, LGTM! 🚀

@prometherion prometherion merged commit 3bd4bc6 into projectcapsule:main Oct 24, 2023
9 checks passed
@oliverbaehler oliverbaehler added this to the v0.4.0 milestone Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants