Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PCI Subsystem ID to diff IVSheme device #23

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Add PCI Subsystem ID to diff IVSheme device #23

merged 1 commit into from
Aug 21, 2024

Conversation

xyzhao2018
Copy link
Contributor

Test Done:

adb reboot twice successfully.
power on, power off work normally.
adb, BT, Wi-Fi audio work normally.

Tracked-On: OAM-120375

@sysopenci
Copy link

Dependent pr program name is not compatable this pr's program name, for more details please check tracked_on

@sysopenci
Copy link

Program name for this pr is not compatable with other dependent prs, for more details please check tracked_on

@sysopenci
Copy link

Program name for this pr is not compatable with other dependent prs, for more details please check tracked_on

@sysopenci sysopenci added Pending Developer Approval Pending Developer Approval Pending PR Review Pending PR Review Engineering Build Not Started Engineering Build Not Started labels Aug 12, 2024
JeevakaPrabu
JeevakaPrabu requested changes Aug 19, 2024
View reviewed changes
Copy link
Collaborator

@JeevakaPrabu JeevakaPrabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IVSheme => IVShmem

JeevakaPrabu
JeevakaPrabu requested changes Aug 19, 2024
View reviewed changes
Copy link
Collaborator

@JeevakaPrabu JeevakaPrabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please define the sub device ids to a meaningful macro

@xyzhao2018
Add PCI Subsystem ID to diff IVShmem device
de33214 
Test Done:

1. adb reboot twice successfully.
2. power on, power off work normally.
3. adb, BT, Wi-Fi audio work normally.

Tracked-On: OAM-120375
Signed-off-by: Zhao, Shirley <shirley.zhao@intel.com>
@sysopenci sysopenci added PR approved and removed Pending PR Review Pending PR Review labels Aug 20, 2024
@sysopenci sysopenci added Developer Approved and removed Pending Developer Approval Pending Developer Approval labels Aug 20, 2024
@sysopenci
Copy link

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci
Copy link

SUCCESS: Android CI has completed Engineering Build for this issue.Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci sysopenci added Engineering Build Successful Engineering Build Successful and removed Engineering Build Not Started Engineering Build Not Started labels Aug 20, 2024
@sysopenci
Copy link

Android CI has started MERGE Build for this pr ,Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci sysopenci merged commit 85169bc into projectceladon:celadon/u/mr0/master Aug 21, 2024
16 checks passed
@sysopenci
Copy link

Android CI has completed MERGE Build for this pr, build is SUCCESS. Please check the linked Tracked-On issue/Android CI Web for more details. For Binaries: /cactus-absp-or-local/celadon_umr0_master-merge/19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeevakaPrabu JeevakaPrabu JeevakaPrabu approved these changes

@dyang23 dyang23 dyang23 approved these changes

@kaushlen kaushlen kaushlen approved these changes

Assignees
No one assigned
Labels
Developer Approved Engineering Build Successful Engineering Build Successful PR approved Valid commit message
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@xyzhao2018 @sysopenci @JeevakaPrabu @dyang23 @kaushlen