Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only set scanout flag for display buffer #159

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Only set scanout flag for display buffer #159

merged 1 commit into from
Oct 9, 2024

Conversation

yhe39
Copy link
Contributor

@yhe39 yhe39 commented Sep 25, 2024

No description provided.

@sysopenci
Copy link

Improper Commit Message
Tracked on not found in commit message,
make sure Tracked-On: Jira-ticket is present.

@sysopenci sysopenci added Pending Developer Approval Pending Developer Approval Pending PR Review Pending PR Review Engineering Build Not Started Engineering Build Not Started labels Sep 25, 2024
feijiang1
feijiang1 approved these changes Sep 30, 2024
View reviewed changes
Copy link

@feijiang1 feijiang1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sysopenci sysopenci added PR approved and removed Pending PR Review Pending PR Review labels Sep 30, 2024
@yhe39
Only set scanout flag for display buffer
0f95718 
Tracked-On: OAM-125304
Signed-off-by: He, Yue <yue.he@intel.com>
chenyanxzhu
chenyanxzhu approved these changes Oct 8, 2024
View reviewed changes
cros_gralloc/cros_gralloc_helpers.cc Outdated
@@ -26,6 +26,9 @@
/* Define to match AIDL PixelFormat::R_8. */
#define HAL_PIXEL_FORMAT_R8 0x38

/* Define to match BufferUsage::GRALLOC_USAGE_PRIVATE_1. */
#define GRALLOC_USAGE_PRIVATE_1 (1 << 29)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already defined as enum in "hardware/libhardware/include/hardware/gralloc.h", which is included in this file already. So maybe remove these 2 lines.

feijiang1
feijiang1 approved these changes Oct 8, 2024
View reviewed changes
Copy link

@feijiang1 feijiang1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sysopenci sysopenci added Developer Approved and removed Pending Developer Approval Pending Developer Approval labels Oct 8, 2024
@sysopenci
Copy link

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci
Copy link

SUCCESS: Android CI has completed Engineering Build for this issue.Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci sysopenci added Engineering Build Successful Engineering Build Successful Pending Developer Approval Pending Developer Approval Developer Approved and removed Engineering Build Not Started Engineering Build Not Started Developer Approved Pending Developer Approval Pending Developer Approval labels Oct 8, 2024
@sysopenci
Copy link

Android CI has started MERGE Build for this pr ,Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci sysopenci merged commit 7a616cf into projectceladon:celadon/u/mr0/master Oct 9, 2024
24 checks passed
@sysopenci
Copy link

Android CI has completed MERGE Build for this pr, build is SUCCESS. Please check the linked Tracked-On issue/Android CI Web for more details. For Binaries: /cactus-absp-or-local/celadon_umr0_master-merge/158

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phreer phreer phreer approved these changes

@feijiang1 feijiang1 feijiang1 approved these changes

@chenyanxzhu chenyanxzhu chenyanxzhu approved these changes

Assignees
No one assigned
Labels
Developer Approved Engineering Build Successful Engineering Build Successful PR approved Valid commit message
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yhe39 @sysopenci @phreer @feijiang1 @chenyanxzhu