Skip to content

Commit

Permalink
update Gateway API conformance exclusions (#6012)
Browse files Browse the repository at this point in the history
Adds comments for excluded Gateway API conformance
tests and syncs run-gateway-conformance.sh with
gateway_conformance_test.go.

Signed-off-by: Steve Kriss <stephen.kriss@gmail.com>
  • Loading branch information
skriss authored Dec 12, 2023
1 parent ec46fff commit 4d48db7
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 2 deletions.
10 changes: 9 additions & 1 deletion test/conformance/gatewayapi/gateway_conformance_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,16 @@ func TestGatewayConformance(t *testing.T) {
// See: https://github.com/envoyproxy/envoy/issues/17318
tests.HTTPRouteRedirectPortAndScheme.ShortName,

// Tests newly failing with Gateway API 1.0, to be addressed.
// Not implemented yet since it's functionally equivalent
// to Timeouts.Request, to be enabled once Gateway API
// supports retries.
// See: https://github.com/projectcontour/contour/issues/6000
tests.HTTPRouteTimeoutBackendRequest.ShortName,

// Contour supports the positive-case functionality,
// but there are some negative cases that aren't fully
// implemented plus complications with the test setup itself.
// See: https://github.com/projectcontour/contour/issues/5922
tests.GatewayStaticAddresses.ShortName,
},
ExemptFeatures: sets.New(
Expand Down
2 changes: 1 addition & 1 deletion test/scripts/run-gateway-conformance.sh
Original file line number Diff line number Diff line change
Expand Up @@ -67,5 +67,5 @@ else
# test/conformance/gatewayapi/gateway_conformance_test.go.
go test -timeout=40m ./conformance -run TestConformance -gateway-class=contour -all-features \
-exempt-features=Mesh \
-skip-tests=HTTPRouteRedirectPortAndScheme
-skip-tests=HTTPRouteRedirectPortAndScheme,HTTPRouteTimeoutBackendRequest,GatewayStaticAddresses
fi

0 comments on commit 4d48db7

Please sign in to comment.