Skip to content

Commit

Permalink
daily build: run E2E's against endpoints translator (#6338)
Browse files Browse the repository at this point in the history
Now that using EndpointSlices is the default behavior,
flip the daily build to continue running E2E's with
the Endpoints translator for coverage until it's
removed.

Signed-off-by: Steve Kriss <stephen.kriss@gmail.com>
  • Loading branch information
skriss committed Apr 12, 2024
1 parent 6bdda0b commit 818ca2d
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/build_daily.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ jobs:
steps: ${{ toJson(steps) }}
channel: '#contour-ci-notifications'
if: ${{ failure() && github.ref == 'refs/heads/main' }}
e2e-endpoint-slices:
e2e-endpoints:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
Expand All @@ -154,7 +154,7 @@ jobs:
- name: e2e tests
env:
CONTOUR_E2E_IMAGE: ghcr.io/projectcontour/contour:main
CONTOUR_E2E_USE_ENDPOINT_SLICES: true
CONTOUR_E2E_USE_ENDPOINTS: true
run: |
make setup-kind-cluster run-e2e cleanup-kind
- uses: act10ns/slack@ed1309ab9862e57e9e583e51c7889486b9a00b0f # v2.0.0
Expand Down
4 changes: 2 additions & 2 deletions test/e2e/fixtures.go
Original file line number Diff line number Diff line change
Expand Up @@ -651,9 +651,9 @@ func XDSServerTypeFromEnv() contour_v1alpha1.XDSServerType {

func UseFeatureFlagsFromEnv() []string {
flags := make([]string, 0)
_, found := os.LookupEnv("CONTOUR_E2E_USE_ENDPOINT_SLICES")
_, found := os.LookupEnv("CONTOUR_E2E_USE_ENDPOINTS")
if found {
flags = append(flags, "useEndpointSlices")
flags = append(flags, "useEndpointSlices=false")
}
return flags
}
Expand Down

0 comments on commit 818ca2d

Please sign in to comment.