Use necojackarc/auto-request-review action to request reviews from non-maintainers #5896

sunjayBhatia · 2023-10-25T18:45:06Z

CODEOWNERS only allows requesting reviews from users/teams with owner permission on the repo

Use this action which should not require the reviewers github team to have owner permissions

sunjayBhatia · 2023-10-25T18:47:11Z

As part of this we might need to disable reviews on the @projectcontour/maintainers team to let this action handle all the reviewer logic

sunjayBhatia · 2023-10-25T18:49:02Z

Also may want to unset this:

contour/.github/dependabot.yml

Line 17 in 6917d85

- projectcontour/maintainers

codecov · 2023-10-25T18:51:26Z

Codecov Report

Merging #5896 (3aaa658) into main (cf8fb1c) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5896   +/-   ##
=======================================
  Coverage   78.66%   78.66%           
=======================================
  Files         138      138           
  Lines       19670    19670           
=======================================
  Hits        15473    15473           
  Misses       3894     3894           
  Partials      303      303

sunjayBhatia · 2023-10-25T19:50:43Z

unfortunately to get access to the secret needed to access teams, had to switch to the pull_request_target event to trigger the workflow on, which then won't run on this PR since the base branch doesn't include the workflow

sunjayBhatia · 2023-10-25T20:04:15Z

we'll likely have to merge this w/o knowing if it works so that PRs have access to the secret/etc. to run this action

skriss · 2023-11-02T15:56:17Z

.github/reviewers.yaml

+
+options:
+  ignore_draft: true
+  number_of_reviewers: 2


Is there any way to ensure that at least one maintainer is selected?

Alternately, we could continue with the CODEOWNERS approach for adding maintainers as reviewers, and use this workflow solely for assigning (non-maintainer) reviewers.

ah yeah there might be a way to do so with the "groups" feature, but it might be simpler to keep the CODEOWNERS and just specify reviewers with this action

Circling back here, I'm in favor of keeping CODEOWNERS for existing maintainers, and using this workflow for assigning non-maintainer reviewers.

github-actions · 2023-11-17T00:19:32Z

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 14d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
Mark this PR as fresh by commenting or pushing a commit
Close this PR
Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

CODEOWNERS only allows requesting reviews from users/teams with owner permission on the repo Use this action which should not require the reviewers github team to have owner permissions Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>

Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>

We'll use CODEOWNERS to request maintainer reviews Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>

sunjayBhatia · 2023-12-05T23:53:43Z

I'll need to regenerate the secret referenced in the workflow as I believe that has expired

sunjayBhatia · 2023-12-06T18:38:41Z

Ok regenerated token and merging

sunjayBhatia added the release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes. label Oct 25, 2023

sunjayBhatia requested a review from a team as a code owner October 25, 2023 18:45

sunjayBhatia requested review from tsaarni, stevesloka and skriss and removed request for a team October 25, 2023 18:45

sunjayBhatia closed this Oct 25, 2023