Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing reviewers team requested reviews #5998

Conversation

sunjayBhatia
Copy link
Member

No description provided.

Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
@sunjayBhatia sunjayBhatia added do not merge Don't merge this PR until this label is removed. release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes. labels Dec 6, 2023
@sunjayBhatia sunjayBhatia requested a review from a team as a code owner December 6, 2023 18:42
@sunjayBhatia sunjayBhatia requested review from stevesloka and skriss and removed request for a team December 6, 2023 18:42
@sunjayBhatia
Copy link
Member Author

Failed with https://github.com/projectcontour/contour/actions/runs/7118843767/job/19382640906?pr=5998

HttpError: Reviews may only be requested from collaborators. One or more of the teams you specified is not a collaborator of the projectcontour/contour repository.

might need to change the team settings

Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
@sunjayBhatia sunjayBhatia reopened this Dec 6, 2023
@sunjayBhatia sunjayBhatia requested review from a team and clayton-gonsalves and removed request for a team December 6, 2023 18:46
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Merging #5998 (e2387ea) into main (9d71639) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5998   +/-   ##
=======================================
  Coverage   78.66%   78.66%           
=======================================
  Files         138      138           
  Lines       19670    19670           
=======================================
  Hits        15473    15473           
  Misses       3894     3894           
  Partials      303      303           

@sunjayBhatia
Copy link
Member Author

sunjayBhatia commented Dec 6, 2023

looks like it worked: https://github.com/projectcontour/contour/actions/runs/7118875289/job/19382750317?pr=5998

added this repo to the list of repos the reviewers team has access to in this org

@sunjayBhatia sunjayBhatia deleted the test-reviewer-team-review-requested branch December 6, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge Don't merge this PR until this label is removed. release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant