remove disabled ingress-conformance run from CI #6032
Conversation
Signed-off-by: Steve Kriss <stephen.kriss@gmail.com>
skriss
added
the
release-note/none-required
skriss
requested review from
stevesloka and
sunjayBhatia
and removed request for
a team
sunjayBhatia
requested review from
a team,
davinci26 and
clayton-gonsalves
and removed request for
a team
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6032 +/- ##
==========================================
+ Coverage 78.68% 78.70% +0.02%
==========================================
Files 138 138
Lines 19675 19717 +42
==========================================
+ Hits 15481 15518 +37
- Misses 3890 3895 +5
Partials 304 304 |
There was a problem hiding this comment.
LGTM
We might just remove the ingress conformance tests from the pipelines too tbh and just leave the makefile task to run them manually
no-one really reviews changes to the repo and since theyre so flaky (no retries/timeouts configurable on http requests) i dont think anyone is actually running them in CI
SGTM, let me make that change here |
Signed-off-by: Steve Kriss <stephen.kriss@gmail.com>
skriss
changed the title
Upstream Ingress conformance is flaky/poorly maintained and
unlikely to reach a state where it can reliably be run in CI.