Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal: replace funcs with the builtin #6062

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

izturn
Copy link
Member

@izturn izturn commented Jan 9, 2024

Signed-off-by: Gang Liu gang.liu@daocloud.io

Signed-off-by: gang.liu <gang.liu@daocloud.io>
@izturn izturn requested a review from a team as a code owner January 9, 2024 08:56
@izturn izturn requested review from skriss and sunjayBhatia and removed request for a team January 9, 2024 08:56
@izturn izturn self-assigned this Jan 9, 2024
@sunjayBhatia sunjayBhatia requested review from a team and davinci26 and removed request for a team January 9, 2024 08:56
@izturn izturn added the release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes. label Jan 9, 2024
@izturn izturn changed the title Internal: replace with the builtin funcs Internal: replace funcs with the builtin Jan 9, 2024
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (af0ffe0) 78.81% compared to head (f7302e8) 78.79%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6062      +/-   ##
==========================================
- Coverage   78.81%   78.79%   -0.02%     
==========================================
  Files         138      138              
  Lines       19765    19750      -15     
==========================================
- Hits        15577    15562      -15     
  Misses       3885     3885              
  Partials      303      303              
Files Coverage Δ
internal/envoy/cluster.go 100.00% <ø> (ø)
internal/xdscache/v3/listener.go 91.89% <ø> (-0.23%) ⬇️

@skriss skriss merged commit b054178 into projectcontour:main Jan 9, 2024
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants