Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use minimum permissions for github token in PR workflows #6068

Conversation

sunjayBhatia
Copy link
Member

@sunjayBhatia sunjayBhatia commented Jan 10, 2024

To address OpenSSF security scan/best practices

Also does a little whitespace cleanup/standardizes YAML indenting

@sunjayBhatia sunjayBhatia added the release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes. label Jan 10, 2024
@sunjayBhatia
Copy link
Member Author

Doing this in pieces to make sure I don't break CI

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (16fa671) 78.81% compared to head (c019f24) 78.81%.
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6068   +/-   ##
=======================================
  Coverage   78.81%   78.81%           
=======================================
  Files         138      138           
  Lines       19778    19778           
=======================================
  Hits        15589    15589           
  Misses       3886     3886           
  Partials      303      303           

@sunjayBhatia sunjayBhatia marked this pull request as ready for review January 10, 2024 21:49
@sunjayBhatia sunjayBhatia requested a review from a team as a code owner January 10, 2024 21:49
@sunjayBhatia sunjayBhatia requested review from tsaarni, skriss, a team and davinci26 and removed request for a team January 10, 2024 21:49
@sunjayBhatia sunjayBhatia force-pushed the github-workflow-token-min-permissions branch from 7e21973 to a93a14e Compare January 10, 2024 21:54
@sunjayBhatia sunjayBhatia changed the title Use minimum permissions for github token in workflows Use minimum permissions for github token in PR workflows Jan 10, 2024
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
@sunjayBhatia sunjayBhatia force-pushed the github-workflow-token-min-permissions branch from a93a14e to c019f24 Compare January 11, 2024 17:49
@sunjayBhatia sunjayBhatia merged commit 6e81b65 into projectcontour:main Jan 11, 2024
26 checks passed
@sunjayBhatia sunjayBhatia deleted the github-workflow-token-min-permissions branch January 11, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants