-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump Envoy to v1.29.0 #6123
bump Envoy to v1.29.0 #6123
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6123 +/- ##
=======================================
Coverage 78.82% 78.82%
=======================================
Files 138 138
Lines 19766 19766
=======================================
Hits 15581 15581
Misses 3878 3878
Partials 307 307
|
Local rate limiting E2E's are failing, will look into it.. Hmm, yeah, can repro per-route local rate limits not taking effect in my dev environment. Will go dig around in the envoy repo. |
Looks like we're being affected by envoyproxy/envoy#29461, will need to either flip the runtime flag back to false or address some inconsistencies in our filter naming. |
should be fine in an upgrade to set the filter names (and not have to bother with the runtime switch) to the canonical names i would think, since older versions of Envoy should work just fine with that config unfortunate this was done without too much warning 🤷🏽 |
Signed-off-by: Steve Kriss <stephen.kriss@gmail.com>
Signed-off-by: Steve Kriss <stephen.kriss@gmail.com>
Closes #6059.