Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump Envoy to v1.29.0 #6123

Merged
merged 3 commits into from
Jan 29, 2024
Merged

bump Envoy to v1.29.0 #6123

merged 3 commits into from
Jan 29, 2024

Conversation

skriss
Copy link
Member

@skriss skriss commented Jan 26, 2024

Closes #6059.

@skriss skriss added the release-note/small A small change that needs one line of explanation in the release notes. label Jan 26, 2024
@skriss skriss requested a review from a team as a code owner January 26, 2024 16:59
@skriss skriss requested review from tsaarni and sunjayBhatia and removed request for a team January 26, 2024 16:59
@sunjayBhatia sunjayBhatia requested review from a team, davinci26 and izturn and removed request for a team January 26, 2024 16:59
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (67c7ec1) 78.82% compared to head (44028ad) 78.82%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6123   +/-   ##
=======================================
  Coverage   78.82%   78.82%           
=======================================
  Files         138      138           
  Lines       19766    19766           
=======================================
  Hits        15581    15581           
  Misses       3878     3878           
  Partials      307      307           
Files Coverage Δ
cmd/contour/gatewayprovisioner.go 43.87% <100.00%> (ø)

@sunjayBhatia sunjayBhatia enabled auto-merge (squash) January 26, 2024 17:39
@skriss
Copy link
Member Author

skriss commented Jan 26, 2024

Local rate limiting E2E's are failing, will look into it..

Hmm, yeah, can repro per-route local rate limits not taking effect in my dev environment. Will go dig around in the envoy repo.

@skriss
Copy link
Member Author

skriss commented Jan 26, 2024

Looks like we're being affected by envoyproxy/envoy#29461, will need to either flip the runtime flag back to false or address some inconsistencies in our filter naming.

@sunjayBhatia
Copy link
Member

Looks like we're being affected by envoyproxy/envoy#29461, will need to either flip the runtime flag back to false or address some inconsistencies in our filter naming.

should be fine in an upgrade to set the filter names (and not have to bother with the runtime switch) to the canonical names i would think, since older versions of Envoy should work just fine with that config

unfortunate this was done without too much warning 🤷🏽

@skriss skriss disabled auto-merge January 26, 2024 21:24
Signed-off-by: Steve Kriss <stephen.kriss@gmail.com>
Signed-off-by: Steve Kriss <stephen.kriss@gmail.com>
Signed-off-by: Steve Kriss <stephen.kriss@gmail.com>
@skriss skriss enabled auto-merge (squash) January 29, 2024 15:29
@skriss skriss merged commit 6ef905a into projectcontour:main Jan 29, 2024
26 checks passed
@skriss skriss deleted the pr-envoy-1.29 branch January 29, 2024 21:29
@skriss skriss mentioned this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/small A small change that needs one line of explanation in the release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update to Envoy 1.29
2 participants