Add disabled-features flag to ContourDeployment for provisioner

[lubronzhan]

Fix #5276

Based on previous art from @padlar #5331.

This PR introduce support for disabled-features in provisioner so that any Contour instances associated with this ContourDeployment with disabled-features flag will stop reconciling CRDs defined inside.

Right now supported values are: grpcroutes;tlsroutes;extensionservices;backendtlspolicies

TODO:

• Add e2e test

[codecov]

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (0809407) 79.35% compared to head (fcabf6f) 79.42%.
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6152      +/-   ##
==========================================
+ Coverage   79.35%   79.42%   +0.06%     
==========================================
  Files         141      141              
  Lines       16107    16133      +26     
==========================================
+ Hits        12782    12813      +31     
+ Misses       3014     3009       -5     
  Partials      311      311              

Files	Coverage Δ
internal/provisioner/controller/gateway.go	57.98% <100.00%> (+0.17%)	⬆️
internal/provisioner/model/model.go	100.00% <100.00%> (ø)
...ernal/provisioner/objects/deployment/deployment.go	89.90% <100.00%> (+0.09%)	⬆️
...ovisioner/objects/rbac/clusterrole/cluster_role.go	64.28% <100.00%> (ø)
internal/provisioner/objects/rbac/role/role.go	63.79% <100.00%> (ø)
internal/provisioner/objects/rbac/util/util.go	100.00% <100.00%> (ø)
internal/provisioner/objects/rbac/rbac.go	10.41% <0.00%> (ø)

... and 1 file with indirect coverage changes

[sunjayBhatia]

just a few comments for now, will do another pass shortly

[lubronzhan]

The upgrade test has many context deadline exceeded issue, is that related to something known issue

2024/02/08 08:34:22.321719 error making request #79: Get "http://172.18.255.200/": context deadline exceeded (Client.Timeout exceeded while awaiting headers)

Didn't find the button to rerun the test

[sunjayBhatia]

I'll wait to merge in case anyone else wants a look but LGTM

[skriss]

Just one docs nit, otherwise LGTM

@sunjayBhatia I'd be fine getting this in for the upcoming release, WDYT?

[sunjayBhatia]

The upgrade test has many context deadline exceeded issue, is that related to something known issue

2024/02/08 08:34:22.321719 error making request #79: Get "http://172.18.255.200/": context deadline exceeded (Client.Timeout exceeded while awaiting headers)

Didn't find the button to rerun the test

yeah, I dont think we made an issue for it but we've seen this a lot I believe since we haven't properly coordinated the Envoy/Contour Service/Deployment redeploy order in the provisioner

Just one docs nit, otherwise LGTM

@sunjayBhatia I'd be fine getting this in for the upcoming release, WDYT?

yep sounds good to me 👍🏽

[skriss]

The upgrade test has many context deadline exceeded issue, is that related to something known issue

2024/02/08 08:34:22.321719 error making request #79: Get "http://172.18.255.200/": context deadline exceeded (Client.Timeout exceeded while awaiting headers)

Didn't find the button to rerun the test

yeah, I dont think we made an issue for it but we've seen this a lot I believe since we haven't properly coordinated the Envoy/Contour Service/Deployment redeploy order in the provisioner

ref. #5375, got closed as stale but still valid to do