-
Notifications
You must be signed in to change notification settings - Fork 681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace ref package with k8s.io/utils/ptr #6189
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6189 +/- ##
==========================================
- Coverage 81.34% 81.33% -0.01%
==========================================
Files 134 133 -1
Lines 15778 15772 -6
==========================================
- Hits 12834 12828 -6
Misses 2650 2650
Partials 294 294
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some new merge conflicts from a recently merged PR but otherwise LGTM (existing package deleted + everything compiles 👍🏽)
718f220
to
1646fdd
Compare
Signed-off-by: lubronzhan <lubronzhan@gmail.com>
1646fdd
to
a0eaab4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix #6163
Right now k8s.io/utils/ptr implements To/Val using generics, we can just use this upstream public library