Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ref package with k8s.io/utils/ptr #6189

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

lubronzhan
Copy link
Contributor

@lubronzhan lubronzhan commented Feb 13, 2024

Fix #6163

Right now k8s.io/utils/ptr implements To/Val using generics, we can just use this upstream public library

@lubronzhan lubronzhan requested a review from a team as a code owner February 13, 2024 07:44
@lubronzhan lubronzhan requested review from skriss and sunjayBhatia and removed request for a team February 13, 2024 07:44
@sunjayBhatia sunjayBhatia requested review from a team, izturn and clayton-gonsalves and removed request for a team February 13, 2024 07:44
@lubronzhan lubronzhan changed the title Replace ref package with k8s.io/utils/ptr [WIP]Replace ref package with k8s.io/utils/ptr Feb 13, 2024
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (bc89948) 81.34% compared to head (a0eaab4) 81.33%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6189      +/-   ##
==========================================
- Coverage   81.34%   81.33%   -0.01%     
==========================================
  Files         134      133       -1     
  Lines       15778    15772       -6     
==========================================
- Hits        12834    12828       -6     
  Misses       2650     2650              
  Partials      294      294              
Files Coverage Δ
internal/contourconfig/contourconfiguration.go 98.69% <100.00%> (ø)
internal/dag/cache.go 97.03% <100.00%> (ø)
internal/dag/ingress_processor.go 98.04% <100.00%> (ø)
internal/dag/policy.go 95.52% <100.00%> (ø)
internal/gatewayapi/listeners.go 100.00% <100.00%> (ø)
internal/ingressclass/ingressclass.go 100.00% <100.00%> (ø)
internal/k8s/statusaddress.go 82.01% <100.00%> (ø)
internal/provisioner/model/model.go 100.00% <100.00%> (ø)
...nternal/provisioner/objects/dataplane/dataplane.go 87.94% <100.00%> (ø)
...ernal/provisioner/objects/deployment/deployment.go 89.90% <100.00%> (ø)
... and 6 more

@sunjayBhatia sunjayBhatia added the release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes. label Feb 13, 2024
@lubronzhan lubronzhan changed the title [WIP]Replace ref package with k8s.io/utils/ptr Replace ref package with k8s.io/utils/ptr Feb 13, 2024
Copy link
Member

@sunjayBhatia sunjayBhatia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some new merge conflicts from a recently merged PR but otherwise LGTM (existing package deleted + everything compiles 👍🏽)

Signed-off-by: lubronzhan <lubronzhan@gmail.com>
Copy link
Member

@skriss skriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@skriss skriss merged commit 6e6d2f7 into projectcontour:main Feb 14, 2024
26 checks passed
@lubronzhan lubronzhan deleted the topic/lubron/fix-6163 branch February 14, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minor improvement: Replacing existing ref package with k8s.io/utils/ptr
3 participants